chore(appsync): improve error message for missing iam authorization mode #33501
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
|
Seems like the PR includes a lot of formatting changes, which are not compatible with the linting setup in the repo. |
garysassano
force-pushed
the
fix-msg
branch
2 times, most recently
from
1c05580 to
c8ee4db
Compare
|
You will need to change this test as well: https://github.com/garysassano/aws-cdk/blob/8b20e712a35ae7b5150bbfabfc94246ae4307745/packages/aws-cdk-lib/aws-appsync/test/appsync-eventapi.test.ts#L364 |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-community-review
gshpychka
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #33465
Reason for this change
The error message when using grant methods like
grantPublish()andgrantSubscribe()on an Event API without IAM authorization mode needs improvement. Currently, users get a confusing error without clear guidance on how to fix it.The error should clearly explain:
Description of changes
Rephrased the error message.
Describe any new or updated permissions being added
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license