docs(logs): document 2 filter resource limit for log subscriptions with sample workaround #35469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
repeat-contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes ##34735.
Reason for this change
We should document that a having two log subscription filters on a log group can result in a resource replacement failing due to the 2 filter limit.
Description of changes
Just updated the docs with a code sample with a workaround that lets users specify as many subscriptions as they want by sending messages to an SNS topic and using SNS topic subscription filters.
Describe any new or updated permissions being added
N/A
Description of how you validated changes
Rosetta.
We may also want to throw a warning if number of subscription filters is more than 1 on a log group (due to the resource replacement issue) and an error if it exceeds 2 (as it will fail on deployment)
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license