Skip to content

Conversation

matoom-nomu
Copy link
Contributor

@matoom-nomu matoom-nomu commented Sep 16, 2025

Issue # (if applicable)

#35498

Reason for this change

The SpecRestApi construct was missing the binaryMediaTypes property that is available in the regular RestApi construct.

Description of changes

  • Added binaryMediaTypes property to SpecRestApiProps interface**: This property accepts an array of strings representing binary media types (e.g., ['image/png', 'application/pdf'])
  • Updated SpecRestApi constructor**: Modified to pass the binaryMediaTypes property to the underlying CfnRestApi resource
  • Updated README documentation: Added usage example showing how to use binaryMediaTypes with SpecRestApi

Describe any new or updated permissions being added

N/A

Description of how you validated changes

  • Added unit tests: Created tests to verify that the binaryMediaTypes property is correctly passed to CloudFormation
  • Added integration tests: Updated existing integration test to include binaryMediaTypes configuration

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team September 16, 2025 05:06
@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Sep 16, 2025
@matoom-nomu matoom-nomu force-pushed the feature/add-binaryMediaTypes-property-to-SpecRestApi branch from 1754d12 to f37a525 Compare September 16, 2025 05:09
@matoom-nomu matoom-nomu force-pushed the feature/add-binaryMediaTypes-property-to-SpecRestApi branch from 2c0ed78 to 18974e5 Compare September 16, 2025 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant