feat(glue): add SNOWFLAKE connection type - #38489
Conversation
github-actions
Bot
added
beginning-contributor
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
425a3a9 to
924edcf
Compare
924edcf to
844b532
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Merge Queue Status
This pull request spent 6 hours 8 minutes 14 seconds in the queue, with no time running CI. Waiting for any of
All conditions
ReasonThe merge conditions cannot be satisfied: the checks did not pass within the automatic checks timeout of 1 hour 49 minutes 31 seconds, derived from this queue's recent CI runtime These checks never reported on this pull request:
These checks were still running:
HintA check that never reports can never satisfy its merge condition. Check that the check names in your merge conditions match what your CI publishes. If you want to requeue this pull request, you can post a This timeout was not configured: set Requeued — the merge queue status continues in this comment ↓. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Hi @otaviomacedo, I added SNOWFLAKE as a supported connection type for Glue Crawler connections. Could you review when you get a chance? |
eabe5b4 to
43d6403
Compare
43d6403 to
a672022
Compare
39119d7 to
8f87c7d
Compare
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Features must contain a change to a README file.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
✅ A exemption request has been requested. Please wait for a maintainer's review.
…ross-repo PRs When the GitHub API returns a 404 for the list reviews endpoint (which can happen for cross-repo PRs from forks or when the PROJEN_GITHUB_TOKEN lacks access to the source repository), treat it as no existing reviews rather than crashing the entire validate-pr job. Previously, the 404 error would propagate up to run().catch() in index.ts, causing the process to exit with code 1 and failing the workflow.
Adds the `ConnectionType.SNOWFLAKE` constant for Snowflake connections
in the aws-glue-alpha module, matching the AWS Glue service value
'SNOWFLAKE'. Users previously had to instantiate a custom connection
type with `new ConnectionType('SNOWFLAKE')`.
Closes aws#35318
🤖🤖🤖 Generated with AI - this code was authored with the help of an AI agent
8f87c7d to
d21a8b9
Compare
|
Exemption Request - This is a simple enum addition adding the SNOWFLAKE connection type constant. The change is backward compatible and follows the exact pattern of existing connection types (e.g., AZURE, MONGODB). The new constant is a static string value that requires no additional README documentation or integration test coverage beyond the existing unit tests. The AWS Glue service documentation already covers Snowflake connection types. |
aws-cdk-automation
added
the
pr-linter/exemption-requested
Add Snowflake connection to existing connection integration test to satisfy PR linter requirement for integration test coverage.
3 participants
Issue # (if applicable)
Closes #35318
Description
Adds the
ConnectionType.SNOWFLAKEconstant to theaws-glue-alphamodule, matching the AWS Glue service value 'SNOWFLAKE'. Previously users had to instantiate a custom connection type vianew ConnectionType('SNOWFLAKE').Changes
packages/@aws-cdk/aws-glue-alpha/lib/connection.ts: Addedpublic static readonly SNOWFLAKE = new ConnectionType('SNOWFLAKE')following the existing pattern for database connection types.packages/@aws-cdk/aws-glue-alpha/test/connection.test.ts: New test asserting theSNOWFLAKEconstant renders asConnectionType: 'SNOWFLAKE'in the synthesizedAWS::Glue::Connectionresource.🤖🤖🤖 Generated with AI - this code was authored with the help of an AI agent.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.