feat(glue-alpha): add a typed secret input to Connection - #38585
Open
otaviomacedo wants to merge 2 commits into
Open
feat(glue-alpha): add a typed secret input to Connection#38585otaviomacedo wants to merge 2 commits into
otaviomacedo wants to merge 2 commits into
Conversation
Connection credentials could only be expressed as plaintext values in the free-form `properties` map, which is emitted verbatim into the template — the only guard was a suppressible synth-time warning, and the path of least resistance put a plaintext secret in the template. Add a typed, discoverable `secret` prop (`ISecretRef`) to `ConnectionOptions`. It is wired to the connection's `SECRET_ID` property, so Glue reads the credentials at runtime and the secret value never appears in the template. The secret reference is merged in after the plaintext scan, so it is not itself flagged. Setting both `secret` and a `SECRET_ID` in `properties` throws. `ISecretRef` (not `ISecret`) is used so the prop passes `awslint:prefer-ref-interface` and avoids dragging the secretsmanager/lambda L2 surface into the module's type closure; because `ISecret extends ISecretRef`, any `secretsmanager.ISecret` is still accepted. `properties` remains the free-form escape hatch, and the plaintext warning stays as defense-in-depth. Addresses the Connection secrets finding from the aws-glue-alpha pre-GA API review.
otaviomacedo
had a problem deploying
to
automation
August 17, 2026 14:34 — with 
GitHub Actions
Failure
GitHub Actions
Failure
Contributor
|
PRs without a linked issue will receive lower priority for review and merging. Please update the description to follow the PR template and include a line like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connection credentials could only be expressed as plaintext values in the
free-form
propertiesmap, which is emitted verbatim into the template — theonly guard was a suppressible synth-time warning, and the path of least
resistance put a plaintext secret in the template.
Add a typed, discoverable
secretprop (ISecretRef) toConnectionOptions.It is wired to the connection's
SECRET_IDproperty, so Glue reads thecredentials at runtime and the secret value never appears in the template. The
secret reference is merged in after the plaintext scan, so it is not itself
flagged. Setting both
secretand aSECRET_IDinpropertiesthrows.ISecretRef(notISecret) is used so the prop passesawslint:prefer-ref-interfaceand avoids dragging the secretsmanager/lambda L2 surface into the module's type
closure; because
ISecret extends ISecretRef, anysecretsmanager.ISecretisstill accepted.
propertiesremains the free-form escape hatch, and theplaintext warning stays as defense-in-depth.
Addresses the Connection secrets finding from the aws-glue-alpha pre-GA API review.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license