Skip to content

Add required field validation to nested structures #9463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 6, 2025
Merged

Add required field validation to nested structures #9463

merged 6 commits into from
May 6, 2025

Conversation

AndrewAsseily
Copy link
Contributor

@AndrewAsseily AndrewAsseily commented Apr 28, 2025 •
edited
Loading

Issue #, if available: CLI-6123

Description of changes:

  • Display of required properties in nested structures

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AndrewAsseily AndrewAsseily requested a review from kdaily April 28, 2025 14:58
@AndrewAsseily
Changed to only check immediate parent for required fields to prevent
67194ea 
false positives when the same field name appears at different levels with
different requirement statuses.
@AndrewAsseily AndrewAsseily reopened this Apr 28, 2025
hssyoo
hssyoo requested changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@hssyoo hssyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, main feedback is to differentiate this work from the constraints PR. We should also have a test for parameters that are expected to have required tags.

@AndrewAsseily AndrewAsseily mentioned this pull request Apr 29, 2025
Closed
@kdaily kdaily changed the base branch from v2 to cli-accessibility April 29, 2025 17:56
@kdaily kdaily merged commit 0f8ab49 into aws:cli-accessibility May 6, 2025
44 of 45 checks passed
@kdaily kdaily mentioned this pull request May 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hssyoo hssyoo hssyoo requested changes

@kdaily kdaily kdaily approved these changes

Assignees
No one assigned
Labels
accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrewAsseily @kdaily @hssyoo