Skip bundled installer tests on pushes to develop #9471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9471 +/- ##
========================================
Coverage 93.39% 93.40%
========================================
Files 210 211 +1
Lines 16983 17000 +17
========================================
+ Hits 15861 15878 +17
Misses 1122 1122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jonathan343
reviewed
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: #9420 recently added a new GitHub Action that runs tests for the CLI V1 bundled installer for Mac and Linux.
During the daily release, we push to GitHub before PyPI. These tests are kicked off, but then fail because the new botocore isn't in PyPI yet.
Example failure: https://github.com/aws/aws-cli/actions/runs/14739584274
I'll look at the internal canaries as a better spot to test that the mainline branch is working.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.