Command and Control integ test fix #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes two issues that were causing command and control tests to fail.
One was error logging in commandandcontrol/replies.steps.ts would fail if it caught a standard error, which we throw in the case of No Job.
The second was that the recent Ephemeral Group change has a 30 second delay on the SQS message it sends.
This is a temporary fix so that tests pass as expected, but we should do additional investigation and document why this 30 second delay is necessary.
Also, a couple of documentation spelling fixes.
Type of change
Submission Checklist