fix: keep filter from erroring when no events are found, additional c… #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcozzi
reviewed
Mar 20, 2024
| @@ -190,7 +190,7 @@ export class FilterService { | |||
| private async listSubscriptionsForEvent( | |||
| ev: CommonEvent, | |||
| subscriptionMap: { [key: string]: SubscriptionItem[] } | |||
| ) { | |||
| ): Promise<SubscriptionItem[]> { | |||
There was a problem hiding this comment.
This should specify that it can return an undefined value. I also wonder, is there any value to returning an undefined value from this function? Why not return undefined as an empty array?
There was a problem hiding this comment.
I updated it. Also, you are correct about the undefined value. I did not want to correct that here and the multiple other places it happens in this CR. This function, it's callers, and the functions it calls should be refactored in a few ways. It's in my notes of things to be addressed.
BenjiTheC
approved these changes
Mar 20, 2024
pcozzi
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: keep filter from erroring when no events are found, additional cleanup
Type of change
Submission Checklist