fix: use the windows api function equivalent to rusage #1470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Building for
GOOS=windowsfails because/aws-cryptographic-material-providers-library/releases/go/smithy-dafny-standard-library/Time_/externs.gois usingsyscall.Rusagewhich doesn't exist in the syscall package for windows builds.The proposed change moves the offending function
GetProcessCpuTimeMillisto another fileexterns_linux_and_darwin.gowhich has a//go:build !windowscompiler directive so this version of the function is use on non-windows systems. A second file,externs_windows.gowith the//go:build windowscompiler directive was added and the same function signature was specified, but it usesGetProcessTimesfrom the windows API to get the same process time information returned bygetrusage.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.