Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend against JDK8 #400

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Recommend against JDK8 #400

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55d7366
Recommend against JDK8
CristianPrundeanu Jul 2, 2024
6c9e92a
update recommendation against jdk8
AWSjswinney Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions java.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ performance benefit until they switched to Java 11.
This page includes specific details about building and tuning Java application on Graviton.

### Java versions
If you are still using JDK8, please stronly consider upgrading. There are significant performance improvements that you can benefit from, such as better JIT code generation, optimized GC at high thread counts, Arm-tuned Java monitors and locks, an improved SpinPause logic (with even more options in JDK17, like OnSpinWaitInstCount and OnSpinWaitInst), and using Arm intrinsics.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/stronly/strongly/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting here (line length) is unlike the surrounding text. Not that it matters for the rendered result, of course.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have them, links for some, or all, of those optimizations would help.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the formatting and spelling, but I didn't add any links.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should rewrite this section with our up-to-date recommendations (>=Corretto17) and put the disclaimer about Corretto8 towards the end.


JDK binaries for arm64 are available from a number of
different sources. [Amazon Corretto](https://aws.amazon.com/corretto/) is
continuing to improve performance of Java workloads running on Graviton processors and
Expand Down