Skip to content

Persistent private keys for agreement #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 18, 2024
Merged

Persistent private keys for agreement #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
61aa0b2
Refactor encoding mod
justsmth Dec 21, 2023
b6f1a26
Persistent private keys for agreement
justsmth Dec 20, 2023
1b9f05d
Refactoring EC marshalling; support agreement::PrivateKey
justsmth Dec 21, 2023
13c4f87
PR feedback; const cleanup
justsmth Jan 2, 2024
4e383b1
Let encoding types be generic over lifetimes
justsmth Jan 5, 2024
2576752
Per PR feedback; only need to verify NID
justsmth Jan 8, 2024
021982e
FIPS key check still needed
justsmth Jan 9, 2024
b4eabdf
Cleanup use of unsafe blocks
justsmth Jan 17, 2024
fea9bf9
Add test w/ invalid inputs
justsmth Jan 17, 2024
3b6b283
Per PR feedback
justsmth Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
721 changes: 419 additions & 302 deletions aws-lc-rs/src/agreement.rs
View file
Open in desktop

Large diffs are not rendered by default.

0 aws-lc-rs/src/data/agreement_tests.txt → ...rs/src/agreement/data/agreement_tests.txt
View file
Open in desktop
File renamed without changes.
462 changes: 462 additions & 0 deletions aws-lc-rs/src/agreement/ephemeral.rs
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 9 additions & 1 deletion aws-lc-rs/src/bn.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,20 @@
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0 OR ISC

use crate::ptr::{ConstPointer, DetachableLcPtr};
use crate::ptr::{ConstPointer, DetachableLcPtr, LcPtr};
use aws_lc::{BN_bin2bn, BN_bn2bin, BN_cmp, BN_new, BN_num_bits, BN_num_bytes, BN_set_u64, BIGNUM};
use mirai_annotations::unrecoverable;
use std::cmp::Ordering;
use std::ptr::null_mut;

impl TryFrom<&[u8]> for LcPtr<BIGNUM> {
type Error = ();

fn try_from(bytes: &[u8]) -> Result<Self, Self::Error> {
unsafe { LcPtr::new(BN_bin2bn(bytes.as_ptr(), bytes.len(), null_mut())) }
}
}

impl TryFrom<&[u8]> for DetachableLcPtr<BIGNUM> {
type Error = ();

Expand Down
Loading