Skip to content

Add null check on RSA key checks #2727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2025
Merged

Add null check on RSA key checks #2727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions crypto/fipsmodule/rsa/rsa.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1270,6 +1270,8 @@ static enum rsa_key_type_for_checking determine_key_type_for_checking(const RSA
// the function can work with.
int RSA_check_key(const RSA *key) {
SET_DIT_AUTO_RESET;
GUARD_PTR(key);

enum rsa_key_type_for_checking key_type = determine_key_type_for_checking(key);
if (key_type == RSA_KEY_TYPE_FOR_CHECKING_INVALID) {
OPENSSL_PUT_ERROR(RSA, RSA_R_BAD_RSA_PARAMETERS);
Expand Down Expand Up @@ -1501,6 +1503,7 @@ DEFINE_LOCAL_DATA(BIGNUM, g_small_factors) {
// approved FIPS services.
int RSA_check_fips(RSA *key) {
SET_DIT_AUTO_RESET;
GUARD_PTR(key);

enum rsa_key_type_for_checking key_type = determine_key_type_for_checking(key);
// In addition to invalid key type, stripped private keys can not be checked
Expand Down
Loading