Skip to content

Include Slurm resume plugin config update to support ScalingStrategy update #2983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Include Slurm resume plugin config update to support ScalingStrategy update #2983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ This file is used to list changes made in each version of the AWS ParallelCluste
**CHANGES**
- Ubuntu 20.04 is no longer supported.

**BUG FIXES**
- Fix an issue where scaling strategy was not updated during a cluster update.

3.13.2
------

Expand Down
2 changes: 2 additions & 0 deletions cookbooks/aws-parallelcluster-slurm/recipes/update/update_head_node.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@
not_if { ::File.exist?(node['cluster']['previous_cluster_config_path']) && !are_queues_updated? && !are_bulk_custom_slurm_settings_updated? }
end

include_recipe 'aws-parallelcluster-slurm::config_slurm_resume'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a unit test verifying that the recipe is always called as part of the update?


ruby_block "update_shared_storages" do
block do
run_context.include_recipe 'aws-parallelcluster-environment::update_shared_storages'
Expand Down
Loading