[Isolated] Update Pypi dependencies and install efs-proxy dependency #3011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 976d479.
…me inside the Tar
….12.8 uses setup.py based installation where it uses a isolated build instead of looking at existing site-packages
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-3.13 #3011 +/- ##
=============================================
Coverage 75.50% 75.50%
=============================================
Files 23 23
Lines 2356 2356
=============================================
Hits 1779 1779
Misses 577 577
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
himani2411
reviewed
Aug 18, 2025
| @@ -32,14 +32,6 @@ | |||
| expect(node.default['cluster']['cookbook_virtualenv_path']).to eq(virtualenv_path) | |||
| is_expected.to write_node_attributes('dump node attributes') | |||
| end | |||
|
|
|||
| it 'installs python packages' do | |||
himani2411
reviewed
Aug 18, 2025
|
|
||
| action :install_utils do | ||
| package_version = new_resource.efs_utils_version | ||
| efs_utils_tarball = "#{node['cluster']['sources_dir']}/efs-utils-#{package_version}.tar.gz" |
There was a problem hiding this comment.
Why is this moved as part of each action?
There was a problem hiding this comment.
you can't use new_resource outside of an actionblock, so I can't define the variable globally because I would not be able to use new_resource
himani2411
reviewed
Aug 18, 2025
| cached(:aws_region) { 'us-iso-test' } | ||
|
|
||
| before do | ||
| allow_any_instance_of(String).to receive(:start_with?).with("us-iso").and_return(true) |
There was a problem hiding this comment.
Lets add the test for both partition where start_with is true and false
hgreebe
force-pushed
the
release-3.13.2-isolated
branch
from
de59cb8 to
ddbc975
Compare
himani2411
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
--no-build-isolationas with Python 3.12.x so that we check for existing dependecies.** packages are installed with isolation from Py 3.12, where they do not check if the dependencies they want already exist and try to install them again.
Tests
Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.