Skip to content

[Subnet Prioritization] Support the new Integeration test #6915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2025
Merged

[Subnet Prioritization] Support the new Integeration test #6915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5513f82
[Subnet Prioritization] Add the new integ test as part of the daily i…
Allenz5 Jul 14, 2025
16387a3
[Subnet Prioritization] Fix format issue in develop.yaml
Allenz5 Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/integration-tests/configs/develop.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,12 @@ test-suites:
instances: {{ common.INSTANCES_DEFAULT_X86 }}
oss: [{{ OS_X86_1 }}]
schedulers: ["slurm"]
test_cluster_networking.py::test_cluster_with_subnet_prioritization:
dimensions:
- regions: [ "us-east-2" ]
instances: [ "t3.large" ]
oss: [{{ OS_X86_1 }}]
schedulers: [ "slurm" ]
test_networking.py::test_public_network_topology:
dimensions:
- regions: ["af-south-1", "us-gov-east-1", "cn-northwest-1"]
Expand Down
11 changes: 5 additions & 6 deletions tests/integration-tests/tests/networking/test_cluster_networking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,13 +257,12 @@ def test_cluster_with_subnet_prioritization(
queues = ["queue1", "queue2"]
logging.info(f"Public subnets: {public_subnets}")
# Check that all instances are launched in the subnet with the highest priority
with soft_assertions():
for queue in queues:
scheduler_commands.submit_command("sleep 60", nodes=5, partition=queue)
wait_for_num_instances_in_queue(cluster.cfn_name, cluster.region, desired=5, queue=queue)
for queue in queues:
scheduler_commands.submit_command("sleep 60", nodes=5, partition=queue)
wait_for_num_instances_in_queue(cluster.cfn_name, cluster.region, desired=5, queue=queue)

subnet_ids = get_compute_nodes_subnet_ids(cluster.cfn_name, region, node_type="Compute", queue_name=queue)
logging.info(f"Subnets: {subnet_ids}")
subnet_ids = get_compute_nodes_subnet_ids(cluster.cfn_name, region, node_type="Compute", queue_name=queue)
with soft_assertions():
for subnet_id in subnet_ids:
assert_that(subnet_id).is_equal_to(public_subnets[0])

Expand Down
Loading