Skip to content

ignore s3 select tests, new aws acconts dont support s3 select #3478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025
Merged

ignore s3 select tests, new aws acconts dont support s3 select #3478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions tests/aws-cpp-sdk-s3-crt-integration-tests/BucketAndObjectOperationTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
#include <aws/core/client/RetryStrategy.h>
#include <aws/core/http/HttpClientFactory.h>
#include <aws/core/http/HttpClient.h>
#include <aws/core/http/standard/StandardHttpRequest.h>
#include <aws/core/monitoring/DefaultMonitoring.h>
#include <aws/core/monitoring/CoreMetrics.h>
#include <aws/core/utils/crypto/Cipher.h>
#include <aws/core/utils/crypto/Factories.h>
#include <aws/core/utils/DateTime.h>
Expand Down Expand Up @@ -50,9 +53,10 @@
#pragma warning(disable: 4127)
#endif //_WIN32

#include <aws/core/http/standard/StandardHttpRequest.h>
#include <aws/core/monitoring/DefaultMonitoring.h>
#include <aws/core/monitoring/CoreMetrics.h>
#if defined(_WIN32)
// disable "warning C4702: unreachable code" from GTEST_SKIP on newer MSVS
#pragma warning(disable: 4702)
#endif

using namespace Aws;
using namespace Aws::Http::Standard;
Expand Down Expand Up @@ -980,6 +984,7 @@ namespace

TEST_F(BucketAndObjectOperationTest, TestObjectOperationWithEventStream)
{
GTEST_SKIP() << "Select objects is not supported on new AWS accounts";
Aws::String fullBucketName = CalculateBucketName(BASE_EVENT_STREAM_TEST_BUCKET_NAME.c_str());
SCOPED_TRACE(Aws::String("FullBucketName ") + fullBucketName);
CreateBucketRequest createBucketRequest;
Expand Down Expand Up @@ -1136,6 +1141,7 @@ namespace

TEST_F(BucketAndObjectOperationTest, TestEventStreamWithLargeFile)
{
GTEST_SKIP() << "Select objects is not supported on new AWS accounts";
Aws::String fullBucketName = CalculateBucketName(BASE_EVENT_STREAM_LARGE_FILE_TEST_BUCKET_NAME.c_str());
SCOPED_TRACE(Aws::String("FullBucketName ") + fullBucketName);
CreateBucketRequest createBucketRequest;
Expand Down Expand Up @@ -1212,6 +1218,7 @@ namespace

TEST_F(BucketAndObjectOperationTest, TestErrorsInXml)
{
GTEST_SKIP() << "Select objects is not supported on new AWS accounts";
SelectObjectContentRequest selectObjectContentRequest;
selectObjectContentRequest.SetBucket("adskflaklfakl");
selectObjectContentRequest.SetKey(TEST_EVENT_STREAM_OBJ_KEY);
Expand Down Expand Up @@ -1242,6 +1249,7 @@ namespace

TEST_F(BucketAndObjectOperationTest, TestErrorsInEventStream)
{
GTEST_SKIP() << "Select objects is not supported on new AWS accounts";
Aws::String fullBucketName = CalculateBucketName(BASE_EVENT_STREAM_ERRORS_IN_EVENT_TEST_BUCKET_NAME.c_str());
SCOPED_TRACE(Aws::String("FullBucketName ") + fullBucketName);
CreateBucketRequest createBucketRequest;
Expand Down
2 changes: 1 addition & 1 deletion tests/aws-cpp-sdk-s3-crt-integration-tests/S3ExpressTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#include <aws/testing/AwsTestHelpers.h>
#include <aws/core/platform/Environment.h>
#include <aws/core/http/HttpResponse.h>
#include <aws/core/utils/HashingUtils.h>
#include <aws/s3-crt/S3CrtClient.h>
#include <aws/s3-crt/model/DeleteBucketRequest.h>
#include <aws/s3-crt/model/CreateBucketRequest.h>
Expand All @@ -19,7 +20,6 @@
#include <aws/s3-crt/model/CreateMultipartUploadRequest.h>
#include <aws/s3-crt/model/UploadPartRequest.h>
#include <aws/s3-crt/model/CompleteMultipartUploadRequest.h>
#include <aws/s3-crt/model/SelectObjectContentRequest.h>
#include <aws/s3-crt/model/ListDirectoryBucketsRequest.h>
#include <aws/s3-crt/model/CreateSessionRequest.h>
#include <aws/s3-crt/model/PutBucketPolicyRequest.h>
Expand Down
11 changes: 10 additions & 1 deletion tests/aws-cpp-sdk-s3-integration-tests/BucketAndObjectOperationTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@
#endif
#endif

#if defined(_WIN32)
// disable "warning C4702: unreachable code" from GTEST_SKIP on newer MSVS
#pragma warning(disable: 4702)
#endif

#include <aws/core/http/standard/StandardHttpRequest.h>


Expand Down Expand Up @@ -1591,9 +1596,9 @@ namespace
DeleteObjectOutcome deleteObjectOutcome = Client->DeleteObject(deleteObjectRequest);
AWS_ASSERT_SUCCESS(deleteObjectOutcome);
}

TEST_F(BucketAndObjectOperationTest, TestObjectOperationWithEventStream)
{
GTEST_SKIP() << "Select objects is not supported on new AWS accounts";
const Aws::String fullBucketName = CalculateBucketName(BASE_EVENT_STREAM_TEST_BUCKET_NAME.c_str());
SCOPED_TRACE(Aws::String("FullBucketName ") + fullBucketName);
CreateBucketRequest createBucketRequest;
Expand Down Expand Up @@ -1672,6 +1677,7 @@ namespace
// This test is to test failed event stream request will not cause crash during retry.
TEST_F(BucketAndObjectOperationTest, TestSelectObjectOperationWithEventStreamFailWithRetry)
{
GTEST_SKIP() << "Select objects is not supported on new AWS accounts";
const Aws::String fullBucketName = CalculateBucketName(BASE_EVENT_STREAM_TEST_BUCKET_NAME.c_str());
SCOPED_TRACE(Aws::String("FullBucketName ") + fullBucketName);
CreateBucketRequest createBucketRequest;
Expand Down Expand Up @@ -1747,6 +1753,7 @@ namespace

TEST_F(BucketAndObjectOperationTest, TestEventStreamWithLargeFile)
{
GTEST_SKIP() << "Select objects is not supported on new AWS accounts";
const Aws::String fullBucketName = CalculateBucketName(BASE_EVENT_STREAM_LARGE_FILE_TEST_BUCKET_NAME.c_str());
SCOPED_TRACE(Aws::String("FullBucketName ") + fullBucketName);
CreateBucketRequest createBucketRequest;
Expand Down Expand Up @@ -1823,6 +1830,7 @@ namespace

TEST_F(BucketAndObjectOperationTest, TestErrorsInXml)
{
GTEST_SKIP() << "Select objects is not supported on new AWS accounts";
SelectObjectContentRequest selectObjectContentRequest;
selectObjectContentRequest.SetBucket("adskflaklfakl");
selectObjectContentRequest.SetKey(TEST_EVENT_STREAM_OBJ_KEY);
Expand Down Expand Up @@ -1853,6 +1861,7 @@ namespace

TEST_F(BucketAndObjectOperationTest, TestErrorsInEventStream)
{
GTEST_SKIP() << "Select objects is not supported on new AWS accounts";
const Aws::String fullBucketName = CalculateBucketName(BASE_EVENT_STREAM_ERRORS_IN_EVENT_TEST_BUCKET_NAME.c_str());
SCOPED_TRACE(Aws::String("FullBucketName ") + fullBucketName);
CreateBucketRequest createBucketRequest;
Expand Down
2 changes: 1 addition & 1 deletion tests/aws-cpp-sdk-s3-integration-tests/S3ExpressTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#include <aws/testing/AwsTestHelpers.h>
#include <aws/core/platform/Environment.h>
#include <aws/core/http/HttpResponse.h>
#include <aws/core/utils/HashingUtils.h>
#include <aws/s3/S3Client.h>
#include <aws/s3/model/DeleteBucketRequest.h>
#include <aws/s3/model/CreateBucketRequest.h>
Expand All @@ -19,7 +20,6 @@
#include <aws/s3/model/CreateMultipartUploadRequest.h>
#include <aws/s3/model/UploadPartRequest.h>
#include <aws/s3/model/CompleteMultipartUploadRequest.h>
#include <aws/s3/model/SelectObjectContentRequest.h>
#include <aws/s3/model/ListDirectoryBucketsRequest.h>
#include <aws/s3/model/CreateSessionRequest.h>
#include <aws/s3/model/PutBucketPolicyRequest.h>
Expand Down
Loading