Migration Tool - PutObjectRequest setters #6001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidh44
commented
Apr 1, 2025
| newMethodName: withBucket | ||
| - org.openrewrite.java.ChangeMethodName: | ||
| methodPattern: com.amazonaws.services.s3.model.ListObjectsV2Request withBucketName(String) | ||
| newMethodName: withBucket |
There was a problem hiding this comment.
Removing these as they are redundant with recent recipe addition to remove in V1SetterToV2
L-Applin
reviewed
Apr 1, 2025
| AccessControlPolicy accessControlList = AccessControlPolicy.builder() | ||
| .build(); | ||
|
|
||
| PutObjectRequest request = /*AWS SDK for Java v2 migration: Transform for PutObjectRequest setter accessControlList is not supported, please manually migrate your code to use the v2 setters: acl, grantReadACP, grantWriteACP - https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/services/s3/model/PutObjectRequest.Builder.html#acl(java.lang.String)*/ |
There was a problem hiding this comment.
Is there an easy way to combine all comments for a method invocation into the same comments?
There was a problem hiding this comment.
Not that I can think of. We'd have to retrieve and parse the comment. Seems better to put on separate lines especially with the links to javadocs.
|
L-Applin
approved these changes
Apr 2, 2025
davidh44
deleted the
hdavidh/migration-tool-putObjRequest-unsupportedSetters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Adds support for S3 POJO transforms:
ObjectTagging, AccessControlListAdds support for
PutObjectRequestsetters:redirectLocation, taggingAdds comments for
PutObjectRequestunsupported setters:sseCustomerKey, sseAwsKeyManagementParams, accessControlListAdds type check for
ObjectMetadataarg inputObject(bucket, key, InputStream, ObjectMetadata), as user could pass in a non variable, e.g. emptynew ObjectMetadata()or mock valueany(ObjectMetadata.class)Testing
Added end to end tests