Skip to content

Removing crt waitForNoResources #6004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025
Merged

Removing crt waitForNoResources #6004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
693bd41
Removing crt waitForNoResources
RanVaknin Apr 2, 2025
5ba6a7b
Reverting changes for non-crt packages
RanVaknin Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...c/test/java/software/amazon/awssdk/http/crt/AwsCrtAsyncHttpClientSpiVerificationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ public static void setup() throws Exception {
@AfterClass
public static void tearDown() {
client.close();
CrtResource.waitForNoResources();
}

private byte[] generateRandomBody(int size) {
Expand Down
1 change: 0 additions & 1 deletion ...nt/src/test/java/software/amazon/awssdk/http/crt/AwsCrtHttpClientSpiVerificationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ public static void setup() throws Exception {
@AfterClass
public static void tearDown() {
client.close();
CrtResource.waitForNoResources();
}

private byte[] generateRandomBody(int size) {
Expand Down
5 changes: 0 additions & 5 deletions ...ts/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/AwsCrtHttpClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,6 @@ public static void beforeAll() {
Log.initLoggingToStdout(Log.LogLevel.Warn);
}

@AfterAll
public static void afterAll() {
CrtResource.waitForNoResources();
}

/**
* default value of connectionAcquisitionTimeout of 10 will fail validatesHttpsCertificateIssuer() test
* */
Expand Down
2 changes: 0 additions & 2 deletions ...rt-client/src/test/java/software/amazon/awssdk/http/crt/AwsCrtHttpClientWireMockTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@ public static void setup() {

@AfterClass
public static void tearDown() {
// Verify there is no resource leak.
CrtResource.waitForNoResources();
executorService.shutdown();
}

Expand Down
5 changes: 0 additions & 5 deletions ...-crt-client/src/test/java/software/amazon/awssdk/http/crt/H1SAsyncServerBehaviorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,6 @@ public static void beforeAll() {
Log.initLoggingToStdout(Log.LogLevel.Warn);
}

@AfterAll
public static void afterAll() {
CrtResource.waitForNoResources();
}

@Override
protected SdkAsyncHttpClient setupClient() {
return AwsCrtAsyncHttpClient.builder()
Expand Down
1 change: 0 additions & 1 deletion ...ients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/ProxyWireMockTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ public void teardown() {
}
EventLoopGroup.closeStaticDefault();
HostResolver.closeStaticDefault();
CrtResource.waitForNoResources();
}

/*
Expand Down
6 changes: 0 additions & 6 deletions .../src/test/java/software/amazon/awssdk/http/crt/internal/AwsCrtConfigurationUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,6 @@
import software.amazon.awssdk.http.crt.TcpKeepAliveConfiguration;

class AwsCrtConfigurationUtilsTest {

@AfterAll
public static void tearDown() {
CrtResource.waitForNoResources();
}

@ParameterizedTest
@MethodSource("cipherPreferences")
void resolveCipherPreference_pqNotSupported_shouldFallbackToSystemDefault(Boolean preferPqTls,
Expand Down
Loading