Replace httpclient.execute call with httpclient.executeOpen as mentioned in deprecation notes of httpclient.execute

[joviegas]

Motivation and Context

The Apache HttpClient 5 execute() method is deprecated with a warning to use executeOpen() instead when we need to keep the response object open after request execution. Our Apache5HttpClient implementation requires keeping the response open because we wrap it in an AbortableInputStream for proper resource management.

This change eliminates the deprecation warning and ensures we're using the recommended API for our use case.

Modifications

1. Apache5HttpClient.java:

   • Replaced deprecated httpClient.execute() with httpClient.executeOpen()
   • Added determineTarget() method that uses RoutingSupport.determineHost() to extract the target host from the request
   • Added proper exception handling to convert HttpException to ClientProtocolException
   • Added necessary imports for RoutingSupport and ClientProtocolException

2. Apache5SdkHttpClient.java:

   • Added executeOpen() method to the delegate implementation to support the new API

3. MetricReportingTest.java:

   • Updated mock setup to use executeOpen() instead of deprecated execute()
   • Cleaned up unused imports
   • Minor formatting improvements

Testing

• All existing unit tests pass without modification
• Updated MetricReportingTest to mock the new executeOpen() method
• Verified that the response handling and AbortableInputStream wrapping continue to work correctly
• No functional changes to the HTTP client behavior - this is purely an API migration

License

• I confirm that this pull request can be released under the Apache 2 license

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Fred1155]

We can also add an test to check the thrown exception since we extracted the logic outside but that's optional

[joviegas]

We can also add an test to check the thrown exception since we extracted the logic outside but that's optional

I investigated adding test cases to verify the exception handling in determineTarget(), but it's not feasible to trigger this code path in practice. The SDK performs validation at the request builder level and in higher-level components, ensuring that only valid targets reach the low-level HTTP client. Any request that would cause RoutingSupport.determineHost() to throw an HttpException is already rejected by the SDK's validation layer before reaching the Apache client.

[github-actions]

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.