Skip to content

Conversation

RanVaknin
Copy link
Contributor

bump jackson to 2.19.0

@RanVaknin RanVaknin requested a review from a team as a code owner August 19, 2025 21:38
@RanVaknin RanVaknin changed the title Feature/master/bump jackson 2.19.0 bump jackson to 2.19.0 Aug 19, 2025
@RanVaknin RanVaknin force-pushed the feature/master/bump-jackson-2.19.0 branch 2 times, most recently from 3e400a9 to 7368947 Compare September 4, 2025 21:32
@RanVaknin RanVaknin added the no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required label Sep 4, 2025
@@ -46,6 +47,7 @@ public final class JsonNodeParser {
*/
public static final JsonFactory DEFAULT_JSON_FACTORY =
JsonFactory.builder()
.enable(StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jackson 2.16.0 introduced a behavior change where this behavior was true and now defaults to false. This caused our test to break.

In order to maintain the same behavior we have to manually enable this config.

more info FasterXML/jackson-core#1038

@RanVaknin RanVaknin force-pushed the feature/master/bump-jackson-2.19.0 branch from 7368947 to 5b852bc Compare September 11, 2025 17:49
Copy link

@RanVaknin RanVaknin added this pull request to the merge queue Sep 11, 2025
Merged via the queue into master with commit 5449862 Sep 11, 2025
38 of 40 checks passed
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants