Skip to content

Conversation

S-Saranya1
Copy link
Contributor

@S-Saranya1 S-Saranya1 commented Sep 8, 2025

S3_EXPRESS_BUCKET business metric feature implementation that tracks when an operation called using the S3 Express feature.

Motivation and Context

Adding business metrics for feature IDs to track S3 Express (feature ID "J") usage in AWS SDK S3 requests. This tracks customer adoption of these S3 feature.

When the bucket name matches S3 Express Ruleset and express credentials are used, the SDK SHOULD track a business metric.

Modifications

  • Added S3ExpressUtils.addS3ExpressBusinessMetricIfApplicable() utility method that adds S3_EXPRESS_BUCKET business metric (feature ID "J") when both S3 Express endpoint resolution and S3 Express auth scheme are used.

  • Modified EndpointResolverInterceptorSpec code generation to call the S3 Express business metrics method during endpoint resolution for S3 service

Testing

  • Added unit tests.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@S-Saranya1 S-Saranya1 requested a review from a team as a code owner September 8, 2025 19:51
…mentation' into somepal/s3-express-featureID-implementation
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
76.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@S-Saranya1 S-Saranya1 merged commit f8000dd into feature/master/feature-ids-implementation Sep 11, 2025
27 of 30 checks passed
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants