-
Notifications
You must be signed in to change notification settings - Fork 936
Feature ID implementation for S3 Express Bucket #6409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
S-Saranya1
merged 4 commits into
feature/master/feature-ids-implementation
from
somepal/s3-express-featureID-implementation
Sep 11, 2025
Merged
Feature ID implementation for S3 Express Bucket #6409
S-Saranya1
merged 4 commits into
feature/master/feature-ids-implementation
from
somepal/s3-express-featureID-implementation
Sep 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
joviegas
reviewed
Sep 9, 2025
...s/s3/src/main/java/software/amazon/awssdk/services/s3/internal/s3express/S3ExpressUtils.java
Outdated
Show resolved
Hide resolved
...es/s3/src/test/java/software/amazon/awssdk/services/s3/s3express/S3ExpressUserAgentTest.java
Outdated
Show resolved
Hide resolved
...es/s3/src/test/java/software/amazon/awssdk/services/s3/s3express/S3ExpressUserAgentTest.java
Outdated
Show resolved
Hide resolved
zoewangg
reviewed
Sep 9, 2025
...src/main/java/software/amazon/awssdk/codegen/poet/rules/EndpointResolverInterceptorSpec.java
Show resolved
Hide resolved
zoewangg
reviewed
Sep 10, 2025
...s/s3/src/main/java/software/amazon/awssdk/services/s3/internal/s3express/S3ExpressUtils.java
Show resolved
Hide resolved
...src/main/java/software/amazon/awssdk/codegen/poet/rules/EndpointResolverInterceptorSpec.java
Show resolved
Hide resolved
zoewangg
approved these changes
Sep 10, 2025
joviegas
approved these changes
Sep 11, 2025
…mentation' into somepal/s3-express-featureID-implementation
|
f8000dd
into
feature/master/feature-ids-implementation
27 of 30 checks passed
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3_EXPRESS_BUCKET business metric feature implementation that tracks when an operation called using the S3 Express feature.
Motivation and Context
Adding business metrics for feature IDs to track S3 Express (feature ID "J") usage in AWS SDK S3 requests. This tracks customer adoption of these S3 feature.
When the bucket name matches S3 Express Ruleset and express credentials are used, the SDK SHOULD track a business metric.
Modifications
Added
S3ExpressUtils.addS3ExpressBusinessMetricIfApplicable()
utility method that adds S3_EXPRESS_BUCKET business metric (feature ID "J") when both S3 Express endpoint resolution and S3 Express auth scheme are used.Modified
EndpointResolverInterceptorSpec
code generation to call the S3 Express business metrics method during endpoint resolution for S3 serviceTesting
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License