S3 DeleteObjects Key Validation Fix #3832
Conversation
AlexDaines
changed the base branch from
aws-sdk-net-v3.7-development
to
development
| Logger.InfoFormat(message); | ||
|
|
||
| ValidationErrors.Add(new DeleteError { | ||
| Key = key.Substring(0, Math.Min(key.Length, 128)) + (key.Length > 128 ? "..." : ""), |
There was a problem hiding this comment.
Min here is not truly required, also does it make sense to trim it it 128 when 1024 length is legit it can be issue when you have common prefix of 128 chars length
| }); | ||
| return; | ||
| } | ||
| if (key.Length > 1024) |
There was a problem hiding this comment.
@AlexDaines I understand this change just skips invalid keys and just sends valid ones with the request to the server. I'm wondering shouldn't this behavior be handled on the server side and proper DeleteObjectsResponse be returned from the server in that case?
|
Closing - After investigation, the real issue is that New PR (#3839) created with the proper exception handling fix instead of client-side validation. |
Description
Modified the S3 client's
DeleteObjectsoperation to properly handle invalid keys in batch delete requests. Instead of failing the entire operation when any single key is invalid, the client now skips invalid keys and proceeds with deleting valid objects. If all keys in a request are invalid, a clear exception is thrown with an appropriate message.Motivation and Context
Addresses open issue #3828
This change is required because the current implementation prevents valid keys from being deleted when any key in the batch is invalid (e.g., too long). The S3 DeleteObjects API is designed to support partial successes, but the client-side validation was preventing this behavior by throwing an
AmazonS3Exceptionbefore the request reached the service.This fix allows the DeleteObjects operation to behave as expected, processing all valid keys even when some invalid keys are present in the same batch.
Testing
The changes were tested with the following scenarios:
Screenshots (if appropriate)
Types of changes
Checklist
License