-
Notifications
You must be signed in to change notification settings - Fork 867
Fix async waiting in DynamoDBRetryPolicy
.
#3842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
DynamoDBRetryPolicy
.DynamoDBRetryPolicy
.
sdk/src/Services/DynamoDBv2/Custom/Internal/DynamoDBRetryPolicy.cs
Outdated
Show resolved
Hide resolved
4675c8d
to
b4853a7
Compare
DynamoDBRetryPolicy
.DynamoDBRetryPolicy
.
Turns out that without this PR, we will not block the thread, but will fall back to the default and non-DynamoDB-specific retry logic. Updated PR title and description. |
Running internal dry run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added dev config and internal dry run succeeded DRY_RUN-8a5da552-276c-4742-9f14-867dc629ab26
.
Description
This PR updates
DynamoDBRetryPolicy
to override theWaitBeforeRetryAsync
method in order to use the updated retry logic for async retries in addition to sync ones.Motivation and Context
Noticed as part of a larger clean-up effort, and split into its own branch.
Testing
N/A
Screenshots (if appropriate)
Types of changes
Checklist
License