Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Python 3.13 & deprecate Python 3.8 #3045

Merged
merged 10 commits into from
Dec 18, 2024

Conversation

kukushking
Copy link
Contributor

@kukushking kukushking commented Dec 16, 2024

Feature or Bugfix

  • Feature

Detail

  • add Python 3.13 support
  • deprecate Python 3.8 (reached end of life 07 Oct 2024)
  • pin Ray to >=2.30.0<2.38 due to breaking changes in Datasink API - update handled in a separate PR

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kukushking kukushking self-assigned this Dec 16, 2024
@malachi-constant

This comment was marked as outdated.

@malachi-constant

This comment was marked as outdated.

@malachi-constant

This comment was marked as outdated.

@malachi-constant

This comment was marked as outdated.

@malachi-constant

This comment was marked as outdated.

@malachi-constant

This comment was marked as outdated.

@kukushking kukushking marked this pull request as ready for review December 17, 2024 12:37
]
ray = { version = "^2.30.0", extras = ["default", "data"], optional = true }
modin = { version = "^0.31.0", optional = true }
ray = { version = ">=2.30.0,<2.38.0", extras = ["default", "data"], optional = true }
Copy link
Contributor Author

@kukushking kukushking Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ray has introduced breaking changes to Datasink API since >=2.38.0. Will open a separate PR for that.

@kukushking kukushking requested a review from a team December 17, 2024 12:40
@malachi-constant

This comment was marked as outdated.

@malachi-constant

This comment was marked as outdated.

@malachi-constant

This comment was marked as outdated.

@malachi-constant

This comment was marked as outdated.

@malachi-constant

This comment was marked as outdated.

@malachi-constant

This comment was marked as outdated.

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 33dce7e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
  • Commit ID: 33dce7e
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant malachi-constant self-requested a review December 17, 2024 16:49
@kukushking
Copy link
Contributor Author

Reproducing test failure with Python 3.13 on Windows did not yiled any results yet:
image

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
  • Commit ID: 33dce7e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking kukushking merged commit ffa44c0 into main Dec 18, 2024
25 of 26 checks passed
@kukushking kukushking deleted the feat/python-3.13 branch December 18, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants