build: migrate Core to a shadow JAR dependency #6112
Conversation
breedloj
changed the title
| <postStartupActivity implementation="software.aws.toolkits.jetbrains.services.telemetry.AwsToolkitStartupMetrics"/> | ||
| </extensions> | ||
| <projectListeners> | ||
| <listener class="software.aws.toolkits.jetbrains.services.telemetry.OpenedFileTypesMetricsListener" topic="com.intellij.openapi.fileEditor.FileEditorManagerListener"/> |
There was a problem hiding this comment.
toolkit should not need this metric
| <depends optional="true">org.jetbrains.idea.maven</depends> | ||
| <resource-bundle>software.aws.toolkits.resources.MessagesBundle</resource-bundle> | ||
|
|
||
| <depends>aws.toolkit.core</depends> |
There was a problem hiding this comment.
<incompatible-with>aws.toolkit.core</incompatible-with>and same below
There was a problem hiding this comment.
Will this force an uninstall? (or at least prompt?)
There was a problem hiding this comment.
i believe it will prompt but not sure what the exact behavior is, should test
Qodana Community for JVM1 new problem were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| implementation(libs.slf4j.jdk14) | ||
| } | ||
|
|
||
| configurations { |
Check warning
Code scanning / QDJVMC
Unstable API Usage Warning
| <depends optional="true">org.jetbrains.idea.maven</depends> | ||
| <resource-bundle>software.aws.toolkits.resources.MessagesBundle</resource-bundle> | ||
|
|
||
| <depends>aws.toolkit.core</depends> |
There was a problem hiding this comment.
i believe it will prompt but not sure what the exact behavior is, should test
2 participants
Types of changes
Description
This change removes Core as an explicit IJ plugin and instead treats it as a more traditional dependency. For flexibility the Core module is shadowed/fat JAR'ed as part of the build process. Any shared build or plugin manifest configuration is referenced independently by the Q and Toolkit plugins.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.