feat(amazonq): grouping options for code issues #6330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
reviewed
Jan 13, 2025
|
|
||
| it('should return fallback when stored state is invalid', function () { | ||
| const invalidStrategy = 'invalid' | ||
| sandbox.stub(globals.globalState, 'tryGet').returns(invalidStrategy) |
There was a problem hiding this comment.
why not just set the globalState? the tests have a fake globalState, it is safe to set it.
sinon and stubs aren't needed.
justinmk3
reviewed
Jan 13, 2025
| const tryGetStub = sandbox.stub(globals.globalState, 'tryGet').returns(undefined) | ||
| const result = state.getState() | ||
|
|
||
| sinon.assert.calledWith(tryGetStub, 'aws.amazonq.codescan.groupingStrategy', String) |
There was a problem hiding this comment.
these kinds of tests are very fragile. can you assert the actual state instead of using stubs/mocks?
justinmk3
reviewed
Jan 13, 2025
| }) | ||
|
|
||
| it('should update state on selection', async function () { | ||
| const spy = sinon.spy(CodeIssueGroupingStrategyState.instance, 'setState') |
There was a problem hiding this comment.
We use "singletons", which presumably are intended to make modules testable. Do we need to stub the global singleton, or can we create a new singleton "object" for testing?
If not, then there is zero reason to have singletons at all, we might as well use plain old modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Code issues are grouped by severity and while this is useful in some cases, it can be hard to navigate.
Solution
Let the user decide how to group the issues.
Grouping strategies to start off with:
feature/xbranches will not be squash-merged at release time.