Pod labels updated to include app.kubernetes.io/version #980
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description of changes
I would like to see the app version added to pods as a label. In addition I moved the merging of selectorLabels into the podLabels out of the deployment and into a new helper.
I'd be curious if merging additionalLabels into the podLabels would also be a good idea since the description of additionalLabels says they are added to all components but that doesn't include the pods created by the deployment. Perhaps that is intentional.
Also, I copied the code for
app.kubernetes.io/managed-by
which will default toHelm
but perhaps that should be removed since technically the pod is managed by the deployment which is managed by Helm...Checklist
README.md
for modified charts)version
inChart.yaml
for the modified chart(s)Testing
None, the test scripts seem to only be helpers. It's a pretty small change though.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.