ci: add memory allocation report #1557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/dhat
branch
from
3cd1d7c to
ec10ee3
Compare
Closed
|
|
||
| - name: Run server | ||
| working-directory: tools/memory-report | ||
| run: ./target/release/memory-report server & |
There was a problem hiding this comment.
What kills the server? Or is it just relying on GitHub killing everything when the workflow completes?
There was a problem hiding this comment.
yep GHA will clean it up
There was a problem hiding this comment.
s2n-quic/.github/workflows/netbench.yml
Line 184 in a7ea209
WesleyRosenblum
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change adds a heap profiler report to track memory usage in s2n-quic. It works by:
tsvwith each of the connection statsdhat-heap.jsonwhich can be viewed by valgrind's dh_view.Call-outs:
The rust
betatests are failing due to a regression rust-lang/rust#103814.Testing:
Report
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.