Skip to content

Enable nightly minor version builds #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

claytonparnell
Copy link
Contributor

@claytonparnell claytonparnell commented Apr 23, 2025

Issue #, if available:

Description of changes:

Add a new workflow which runs on the 1st-10th of each month, triggering minor version build every day. Reads support_policy.md to determine active Major versions, then checks build_artifacts/v* to determine the latest minor/patch version per major version. Calls build-image for minor version, using latest patch of each major version as base.

Also update build-image to allow for repeated calls for same version, with two main changes:

  1. If branch already exists, merge main into it. If not, create new branch.
  2. If PR already exists, fetch the PR ID for calling CodeBuild. If not, create new PR.

Ran locally using act, got output matrix={"version":["1.13.1","2.5.0","3.0.0"]} as expected:

[Kickoff nightly Minor version builds/Generate version matrix] ⭐ Run Set up job
[Kickoff nightly Minor version builds/Generate version matrix] 🚀  Start image=catthehacker/ubuntu:act-latest
[Kickoff nightly Minor version builds/Generate version matrix]   🐳  docker pull image=catthehacker/ubuntu:act-latest platform= username= forcePull=true
[Kickoff nightly Minor version builds/Generate version matrix]   🐳  docker create image=catthehacker/ubuntu:act-latest platform= entrypoint=["tail" "-f" "/dev/null"] cmd=[] network="host"
[Kickoff nightly Minor version builds/Generate version matrix]   🐳  docker run image=catthehacker/ubuntu:act-latest platform= entrypoint=["tail" "-f" "/dev/null"] cmd=[] network="host"
[Kickoff nightly Minor version builds/Generate version matrix]   🐳  docker exec cmd=[node --no-warnings -e console.log(process.execPath)] user= workdir=
[Kickoff nightly Minor version builds/Generate version matrix]   ✅  Success - Set up job
[Kickoff nightly Minor version builds/Generate version matrix] ⭐ Run Main actions/checkout@v4
[Kickoff nightly Minor version builds/Generate version matrix]   🐳  docker cp src=/local/home/crpjr/sagemaker-distribution/. dst=/local/home/crpjr/sagemaker-distribution
[Kickoff nightly Minor version builds/Generate version matrix]   ✅  Success - Main actions/checkout@v4 [1.359867649s]
[Kickoff nightly Minor version builds/Generate version matrix] ⭐ Run Main echo run_name
[Kickoff nightly Minor version builds/Generate version matrix]   🐳  docker exec cmd=[bash -e /var/run/act/workflow/1] user= workdir=
[Kickoff nightly Minor version builds/Generate version matrix] Kickoff Minor nightly builds 04-23-2025
[Kickoff nightly Minor version builds/Generate version matrix]   ✅  Success - Main echo run_name [116.85246ms]
[Kickoff nightly Minor version builds/Generate version matrix] ⭐ Run Main Get supported Major versions
[Kickoff nightly Minor version builds/Generate version matrix]   🐳  docker exec cmd=[bash -e /var/run/act/workflow/supported-major-versions] user= workdir=
[Kickoff nightly Minor version builds/Generate version matrix]   ✅  Success - Main Get supported Major versions [119.38658ms]
[Kickoff nightly Minor version builds/Generate version matrix]   ⚙  ::set-output:: majors=["1","2","3"]
[Kickoff nightly Minor version builds/Generate version matrix] ⭐ Run Main Generate base patch version matrix
[Kickoff nightly Minor version builds/Generate version matrix]   🐳  docker exec cmd=[bash -e /var/run/act/workflow/gen-mat] user= workdir=
[Kickoff nightly Minor version builds/Generate version matrix]   ✅  Success - Main Generate base patch version matrix [129.458025ms]
[Kickoff nightly Minor version builds/Generate version matrix]   ⚙  ::set-output:: matrix={"version":["1.13.1","2.5.0","3.0.0"]}
[Kickoff nightly Minor version builds/Generate version matrix] ⭐ Run Complete job
[Kickoff nightly Minor version builds/Generate version matrix] Cleaning up container for job Generate version matrix
[Kickoff nightly Minor version builds/Generate version matrix]   ✅  Success - Complete job

Patch versions will need more discussion for the cadence we want to use

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@claytonparnell claytonparnell requested a review from a team as a code owner April 23, 2025 20:41
@claytonparnell claytonparnell changed the title Enable nightly minor version releases Enable nightly minor version builds Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants