Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java V2 updates the POM files to use JDK 21 #7327

Merged
merged 72 commits into from
Apr 7, 2025
Merged

Conversation

scmacdon
Copy link
Contributor

This pull request updates the POM files to use JDK 21


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@scmacdon scmacdon added Java-v2 This issue relates to the AWS SDK for Java V2 Task A general update to the code base for language clarification, missing actions, tests, etc. labels Mar 26, 2025
@scmacdon scmacdon self-assigned this Mar 26, 2025
@scmacdon scmacdon changed the title Java V2 updated POM to use JDK 21 Java V2 updates the POM files to use JDK 21 Mar 26, 2025
@scmacdon scmacdon requested review from DavidSouther and tkhill-AWS and removed request for DavidSouther April 3, 2025 13:29
@tkhill-AWS
Copy link
Collaborator

It looks like there are still a couple of 17 in the bedrock examples:

javav2/example_code/bedrock
pom.xml
        <java.version>17</java.version>
javav2/example_code/bedrock-agents-runtime
pom.xml
    <java.version>17</java.version>

@tkhill-AWS
Copy link
Collaborator

Run the following prompt in ChatGPT:

In the context of maven, do I need to specify both properties 'java.version' and 'maven.compiler.target' together with 'maven.compiler.source'?

We can do away with maven.compiler.target and maven.compiler.source

Copy link
Collaborator

@tkhill-AWS tkhill-AWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put a couple comments in the main PR page.

@scmacdon scmacdon added the On Call Review complete On call review complete label Apr 7, 2025
@scmacdon scmacdon merged commit 9fcf126 into awsdocs:main Apr 7, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java-v2 This issue relates to the AWS SDK for Java V2 On Call Review complete On call review complete Task A general update to the code base for language clarification, missing actions, tests, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants