fix: add missing tsconfig.json for VPC resources CDK tutorial (#1245)#1400
Open
madhununna wants to merge 1 commit intoawslabs:mainfrom
Open
fix: add missing tsconfig.json for VPC resources CDK tutorial (#1245)#1400madhununna wants to merge 1 commit intoawslabs:mainfrom
madhununna wants to merge 1 commit intoawslabs:mainfrom
Conversation
The 03-advanced-concepts/07-connect-to-vpc-resources tutorial ships a TypeScript CDK project (bin/app.ts, lib/vpc-fargate-stack.ts, cdk.json using ts-node) but was missing tsconfig.json, so 'npm run build' and 'cdk synth' failed with TypeScript compiler errors. Adds a standard CDK TypeScript tsconfig (matches 'cdk init app --language typescript' template) — verified with: npm install && ./node_modules/.bin/tsc --noEmit # exits 0 ./node_modules/.bin/cdk synth # produces valid CFN Fixes awslabs#1245
github-actions
Bot
added
01-tutorials
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing
tsconfig.jsonin01-tutorials/01-AgentCore-runtime/03-advanced-concepts/07-connect-to-vpc-resources/.Context
Issue #1245 reported that
tsconfig.jsonis missing from this tutorial. The directory ships a TypeScript CDK project:bin/app.ts,lib/vpc-fargate-stack.ts(TypeScript sources)cdk.jsonwith"app": "npx ts-node --prefer-ts-exts bin/app.ts"package.jsonwith"build": "tsc"and devDependencies:typescript,ts-node,aws-cdkWithout
tsconfig.json,npm run build,cdk synth, andcdk deployall fail with TypeScript compiler errors.Fix
Added a standard CDK TypeScript
tsconfig.json(the same template generated bycdk init app --language typescript).Verification
Ran locally in the tutorial directory:
Fixes #1245