Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nw socket shutdown2 #709

Open
wants to merge 22 commits into
base: nw_socket
Choose a base branch
from
Open

Nw socket shutdown2 #709

wants to merge 22 commits into from

Conversation

bretambrose
Copy link
Contributor

Applies the changes in #708 to the nw_socket branch. Removes all dispatch queue sleep invocations in tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.99%. Comparing base (6a95f72) to head (8424ba6).

Files with missing lines Patch % Lines
source/event_loop.c 85.71% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           nw_socket     #709      +/-   ##
=============================================
+ Coverage      77.97%   77.99%   +0.01%     
=============================================
  Files             30       30              
  Lines           6353     6366      +13     
=============================================
+ Hits            4954     4965      +11     
- Misses          1399     1401       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants