Let aws-sdk retry upload especially when conflict with parallel uploads#131
Open
ikedam wants to merge 1 commit intoawslabs:masterfrom
Open
Let aws-sdk retry upload especially when conflict with parallel uploads#131ikedam wants to merge 1 commit intoawslabs:masterfrom
ikedam wants to merge 1 commit intoawslabs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#129
Description of changes:
Parallel execution of
awsCodeBuildresults fillowing error:This means aws-sdk tries to retry upload using
InputStream#reset( https://docs.oracle.com/javase/8/docs/api/java/io/InputStream.html#reset-- ) but it failed.Actually, I'm not so sure why
reset()it fails but we can easily retry that re-opening the target file.I introduced
ResetableFilePathInputStreamwhich re-opens the file ifreset()is called.This contribution is under the Apache 2.0 license.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.