Do not require coreLibraryDesugaring on Android
#914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `java.time` package is only available natively on Android API 28+. Using it forces consuming apps to enable `coreLibraryDesugaring` to support older API levels. This library currently uses `java.time.Instant` only to log the current date, which can be done easily using the old `java.util.Date`. Do note that the exact output of `Instant.toString()` depends on the JDK version, so the resulting string is not necessarily the same, but the current one should be OK for logging purposes.
|
This is currently impacting I'm all for using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
java.timepackage is only available natively on Android API 28+. Using it forces consuming apps to enablecoreLibraryDesugaringto support older API levels.This library currently uses
java.time.Instantonly to log the current date, which can be done easily using the oldjava.util.Date.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.