Fix async generator stop iteration #129
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 3, 2025 14:56
- Replace manual __anext__() calls with async for loop syntax - Replace manual next() calls with for loop syntax - Change exception handling from catching StopIteration to using try-finally - Async generators now properly complete without raising exceptions - Ensure metrics are always flushed even when exceptions occur Fixes awslabs#128
…h yield - Remove flush calls after each yield in generators - Metrics are now flushed only when generator completes (in finally block) - Improves performance by reducing flush operations - Maintains correctness with guaranteed flush on completion or exception
jaheyy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #128
This PR fixes the async generator bug where generators would always throw exceptions on completion due to incorrectly catching
StopIterationinstead ofStopAsyncIteration.Changes
Commit 1: Bug Fix (fix:)
Commit 2: Performance Optimization (perf:)