Conversation
mayakost
requested review from
a team,
HaoOliv,
LeeroyHannigan,
NetDevAutomate,
Rahul-1404,
Wook133,
aemada-aws,
ajain13,
akeyesamzn,
amzn-erdemkemer,
andywidjaja,
ashuanand1226,
biagic,
charlie-7,
chittev,
hvital,
juhala-aws,
kdbrogan,
matthewgoodman13,
nineonine,
prajwalendra,
shsrams,
tusharbabbar,
vishaalmehrishi,
ychamare and
ysunio
as code owners
mayakost
requested review from
a team,
PCManticore,
arnewouters,
bidesh,
iddv,
jcshepherd,
kumvprat and
rshevchuk-git
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3184 +/- ##
==========================================
- Coverage 92.49% 92.49% -0.01%
==========================================
Files 859 859
Lines 68021 68023 +2
Branches 10900 10900
==========================================
+ Hits 62919 62920 +1
Misses 3080 3080
- Partials 2022 2023 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
prajwalendra
left a comment
prajwalendra
left a comment
There was a problem hiding this comment.
Approving only for Openapi-mcp-server has it it a patch upgrade. for other mcps, it may have breaking changes and need separate reviews.
mayakost
dismissed stale reviews from scottschreckengaust and prajwalendra
via
5da3c53
…anagement Use module-level fastmcp.settings for debug config instead of removed FastMCP instance attributes. Update bvs_tools tests to use __fastmcp__ attribute for tool name assertions.
The aws_pricing function expects filters as Optional[str] (JSON string), but the test was passing a dict, causing a pyright type error.
|
@mayakost , I think this may have significant changes as the new major version has breaking changes. I have only done it for OpenAPI-MCP-Server as it has considerable changes including adopting a few important new features. I see a minor patch upgrade in openapi-mcp-server uv.lock. I would simply take that as a separate simple PR. I also suggest server-wise upgrades where it is impacting the code. @scottschreckengaust , |
3 participants
Fixes
Summary
Changes
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change? (Y/N)
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.