Skip to content

Add requester process's PID to Filesystem logs#1718

Open
mansi153 wants to merge 3 commits intoawslabs:mainfrom
mansi153:pid_in_logs
Open

Add requester process's PID to Filesystem logs#1718
mansi153 wants to merge 3 commits intoawslabs:mainfrom
mansi153:pid_in_logs

Conversation

@mansi153
Copy link
Copy Markdown
Contributor

@mansi153 mansi153 commented Dec 4, 2025

Add requester's PID to Filesystem logs.
It also adds an entry point "New request" log to all the (supported) filesystem methods as a proxy for tracking incoming requests at FUSER.

This makes it easier to trace requests dispatched to Mountpoint, especially during workflows using multiple customer processes to make requests concurrently for the same inode(s).

Additionally, the commit adds/re-orders some other fields in the logs (for a few FS methods) to reattain a consistent order of logging request parameters.

Sample log:

2025-12-04T14:56:23.330127Z DEBUG ThreadId(11) lookup{req=3 ino=1 name="._." pid=1860}:head_object{id=3 bucket="multinictesting-iad-benchmarksetupbucket07d0221d-jc1kskgzz2gx" key="._."}: mountpoint_s3_client::s3_crt_client::head_object: new request

The commit also does some minor refactoring to name unused method parameters more consistent and adhering to Rust guidelines.

Does this change impact existing behavior?

No, only (warn-level and higher) logging change.
No breaking changes.

Does this change need a changelog entry? Does it require a version change?

No, and no.
Logging change only.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

Comment thread mountpoint-s3-fuser/src/ll/request.rs
Comment thread mountpoint-s3-fs/src/fuse.rs
Comment thread mountpoint-s3-fs/src/fuse.rs Outdated
Mansi Pandey added 2 commits January 7, 2026 12:55
The commit also does some minor refactoring to name unused method parameters more consistent and adhering to Rust guidelines.

Signed-off-by: Mansi Pandey <[email protected]>
@mansi153 mansi153 had a problem deploying to PR integration tests January 7, 2026 12:59 — with GitHub Actions Failure
@mansi153 mansi153 changed the title Add requester process's PID to Fuse logs and FS logs Add requester process's PID to Filesystem logs Jan 7, 2026
Signed-off-by: Mansi Pandey <[email protected]>
@mansi153 mansi153 temporarily deployed to PR integration tests January 7, 2026 13:14 — with GitHub Actions Inactive
Copy link
Copy Markdown
Contributor

@passaro passaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. It does need a new version and a short entry in the changelog.

Comment thread mountpoint-s3-fs/src/fuse.rs
Copy link
Copy Markdown
Contributor

@dannycjones dannycjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase, and add changelog and version bump. Then I think we can merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants