Add requester process's PID to Filesystem logs#1718
Open
mansi153 wants to merge 3 commits intoawslabs:mainfrom
Open
Add requester process's PID to Filesystem logs#1718mansi153 wants to merge 3 commits intoawslabs:mainfrom
mansi153 wants to merge 3 commits intoawslabs:mainfrom
Conversation
dannycjones
reviewed
Dec 4, 2025
added 2 commits
January 7, 2026 12:55
The commit also does some minor refactoring to name unused method parameters more consistent and adhering to Rust guidelines. Signed-off-by: Mansi Pandey <[email protected]>
Signed-off-by: Mansi Pandey <[email protected]>
Signed-off-by: Mansi Pandey <[email protected]>
passaro
reviewed
Jan 23, 2026
Contributor
passaro
left a comment
There was a problem hiding this comment.
The change looks good. It does need a new version and a short entry in the changelog.
dannycjones
requested changes
Mar 18, 2026
Contributor
dannycjones
left a comment
There was a problem hiding this comment.
Rebase, and add changelog and version bump. Then I think we can merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add requester's PID to Filesystem logs.
It also adds an entry point "New request" log to all the (supported) filesystem methods as a proxy for tracking incoming requests at FUSER.
This makes it easier to trace requests dispatched to Mountpoint, especially during workflows using multiple customer processes to make requests concurrently for the same inode(s).
Additionally, the commit adds/re-orders some other fields in the logs (for a few FS methods) to reattain a consistent order of logging request parameters.
Sample log:
The commit also does some minor refactoring to name unused method parameters more consistent and adhering to Rust guidelines.
Does this change impact existing behavior?
No, only (warn-level and higher) logging change.
No breaking changes.
Does this change need a changelog entry? Does it require a version change?
No, and no.
Logging change only.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).