-
Couldn't load subscription status.
- Fork 118
Update toolchain and doc for 6.2 #564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No blockers, one query
| uses: actions/checkout@v4 | ||
| with: | ||
| persist-credentials: false | ||
| # GitHub checkout action has a dep on NodeJS 20 which is not running on Amazonlinux2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What version of node is installed? The v2 action requires node 24 or higher
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazon Linux doesn't have Node 24, this is the "normal" dance when using Amazon Linux 2.
I hope to get an Amazon Linux 2023 Swift image soon (at least a nightly build), I will upgrade to ALI2023 when available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I got mixed up between AL2 and AL2023 😅
| // That job runs on GitHub's ubuntu-latest environment that only supports Swift 6.1 | ||
| // https://github.com/actions/runner-images?tab=readme-ov-file | ||
| // https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md | ||
| // We can update to Swift 6.2 when GitHUb hosts will have Swift 6.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tracking here actions/runner-images#13068
In preparation for the 2.0.0 GA release,
.swift-version,Package.swiftand all examples'package.swiftto Swift 6.22.0.0-beta.3to2.0.0. This includes the doc and readme, but also the dependencies in the examplesPackage.swift. This will temporary break the build of the examples, until we tag v2.0.0. Note the CI will not be affected as its consumes the local version of the library