Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multisig-protobufs): mark sender field as deprecated and add new field with proper type #2232

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

jcs47
Copy link
Contributor

@jcs47 jcs47 commented Jan 29, 2025

Description

The axelar protobufs for the multisig package have a implementation mistake in which the sender field is declared as a string rather than a byte array. This is not an issue in golang, since in that language the string type is equivalent to the byte array type, and one type can be trivially cast into the other. But this is not the case for all languages, which can create defective code when compiling the protobufs and encoding/decoding the sender field. To solve this problem, this PR replaces the old sender field for a new field with the proper type.

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues
  • Tag type of change
  • Upgrade handler

Steps to Test

Expected Behaviour

Other Notes

@jcs47 jcs47 requested a review from a team as a code owner January 29, 2025 00:53
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.37%. Comparing base (ee4809d) to head (b49de16).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2232      +/-   ##
==========================================
- Coverage   39.45%   39.37%   -0.09%     
==========================================
  Files         375      375              
  Lines       37417    37417              
==========================================
- Hits        14763    14732      -31     
- Misses      21706    21735      +29     
- Partials      948      950       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcs47 jcs47 added the next release Required for the next release label Jan 29, 2025
@cgorenflo cgorenflo merged commit ef91531 into main Jan 30, 2025
9 of 10 checks passed
@cgorenflo cgorenflo deleted the fix/multising_sender_type branch January 30, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release Required for the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants