fix(multisig-protobufs): mark sender field as deprecated and add new field with proper type #2232
+513
−131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The axelar protobufs for the multisig package have a implementation mistake in which the sender field is declared as a string rather than a byte array. This is not an issue in golang, since in that language the string type is equivalent to the byte array type, and one type can be trivially cast into the other. But this is not the case for all languages, which can create defective code when compiling the protobufs and encoding/decoding the sender field. To solve this problem, this PR replaces the old sender field for a new field with the proper type.
Todos
Steps to Test
Expected Behaviour
Other Notes