axiom: pool compression writers to avoid per-call allocations#413
Merged
Conversation
35dcde5 to
caa62a5
Compare
Contributor
|
Can you share the benchmark results for time and allocations too? |
Collaborator
Author
|
@tsenart Here's the full
Compression ratio and output size are identical across old/new (all samples equal). |
tsenart
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pool
zstd.Encoderandgzip.Writerinstances inencoder.goto eliminate the ~4 MB allocation perzstd.NewWritercall (and ~800 KB pergzip.NewWriterLevel). All code paths benefit:ZstdEncoder(),GzipEncoder(),GzipEncoderWithLevel(), andIngestEventsindatasets.go. Adapters (zap, zerolog, slog, etc.) need zero changes since they call the public encoder functions.Adds a public
WriteResetterinterface and genericNewPooledEncoder[T]()helper so users can pool custom compressors the same way.Supersedes #412 with a consolidated approach that covers all encoder call sites, not just
datasets.go.Benchmarks
Compression ratio and output size are unchanged (all samples equal).