[Updated] home style and translation#46
Merged
jasonsaayman merged 5 commits intoaxios:masterfrom Oct 11, 2021
Merged
Conversation
`assets/style/index.scss` file updated and some commented statements uncommented so the desired css files will be generated, also some rules added back where it was exists in the css file but not in the scss file so now compiling the SCSS file will generate correct CSS files.
moved RTL specific styles up to the above of media queries so it's more scannable when others want to make changes this is a convention I picked up during CSS development and it's very helpful for future contributors.
- Corrected subheading in the kurdish translations where some english words where leaved mistakenly before. - Added these new fields for better translation of the home page, also updated the english file as it's the base language: - Website Copy Right Footer - View On Github - Axios Project Copy Right Footer - License Label Footer
Member
|
Thanks for this pull request :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Style changes
assets/style/index.scssfile updated and some commented statementsuncommented so the desired css files will be generated, also some rules
added back where it was exists in the css file but not in the scss file
so now compiling the SCSS file will generate correct CSS files.
Moved RTL specific styles up to the above of media queries
so it's more scannable when others want to make changes
this is a convention I picked up during CSS development and
it's very helpful for future contributors.
Translation changes
words where leaved mistakenly before.
updated the English file as it's the base language:
Completes #45