APO demo part 1: Refactor package name for existing demo#294
Open
mnhnam-axonivy wants to merge 5 commits into
Open
APO demo part 1: Refactor package name for existing demo#294mnhnam-axonivy wants to merge 5 commits into
mnhnam-axonivy wants to merge 5 commits into
Conversation
- Move classes related to business demos to package "erp"
- Remove unnecessary comments
- reduce warnings
- Create test for existing demo
This reverts commit f38faf7.
ivy-rew
approved these changes
Jun 3, 2026
Member
ivy-rew
left a comment
ivy-rew
left a comment
There was a problem hiding this comment.
Thanks for slicing it down; this looks good 👍
Member
|
ready to merge: I think it would be best if we merge on PR at a time to master ... and not pilling it up before doing a big merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I moved the classes and data classes used by the business-related demos into the erp package.
Although there are many file changes, they mainly consist of package refactoring, warning reductions, and general code cleanup. No functional changes are intended.