Skip to content

Commit

Permalink
All XS tickets in the right click milestone: #666, #591, #667, #663,
Browse files Browse the repository at this point in the history
…#685, #684, #649, #596, #670, #577, #360, #522, and #682 (#726)

* For ticket #666, dynamic RF name based on strategy

When altering/creating a keyspace, the `Replication Factor` name would be changed to be `Data Center Replication Factor` in case the set strategy is `NetworkTopology`

* For ticket #591, added `Mandatory` badge to required fields on keyspace creation

- Now a badge `Mandatory` is showed for the `Keyspace Name` field; to tell that it's a required field to complete the creation process.

- Improved the style of other mandatory fields in connection addition process - host name and port -.

* For ticket #667, warning about keyspace name in alter process has been removed

The warning `The keyspace name can't be altered` has been removed; as the field is disabled already.

* For ticket #663, altering warning for name has been removed everywhere

- Similar to #667 ticket, the altering warning for standard table's name has been removed.
- Also, it has been removed when altering counter tables and UDTs.

* For ticket #685, improved the metadata treeview, changed icons for partition and clustering keys

The icon of both; partition and clustering keys have been changed in order to be clearly distinguished

* For ticket #684

* For ticket #649, and ticket #670 - handled in previous commits -

* For ticket #577

* For ticket #360

* For ticket #522

* For ticket #682
  • Loading branch information
mhmdkrmabd authored Feb 18, 2025
1 parent 2b515df commit ebeb985
Show file tree
Hide file tree
Showing 11 changed files with 475 additions and 75 deletions.
334 changes: 327 additions & 7 deletions package-lock.json

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions renderer/assets/images/icons/github.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
30 changes: 20 additions & 10 deletions renderer/js/events/clusters.js
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,8 @@

$('div.body div.right').addClass('hide-content-info')

clusterElement.children('div.status').removeClass('failure').addClass('success')

try {
// If the work area does not exist then skip this try-catch block
if (contentCluster.length <= 0)
Expand Down Expand Up @@ -787,13 +789,13 @@
<div class="header">
<div class="cluster-tabs">
<ul class="nav nav-tabs nav-justified mb-3" id="ex-with-icons" role="tablist">
<li class="nav-item" role="presentation" tab-tooltip data-tippy="tooltip" data-mdb-placement="bottom" data-mulang="CQLSH session" capitalize data-title="CQLSH Session">
<li class="nav-item" role="presentation" tab-tooltip data-tippy="tooltip" data-mdb-placement="bottom" data-mulang="CQL console" capitalize data-title="CQL console">
<a class="nav-link btn btn-tertiary active" data-mdb-ripple-color="dark" data-mdb-toggle="tab" href="#_${cqlshSessionContentID}" role="tab" aria-selected="true">
<span class="icon">
<ion-icon name="terminal"></ion-icon>
</span>
<span class="title">
<span mulang="CQLSH session" capitalize></span>
<span mulang="CQL console" capitalize></span>
</span>
</a>
</li>
Expand Down Expand Up @@ -3143,7 +3145,7 @@

// Add log
try {
addLog(`CQLSH session created for the connection '${getAttributes(clusterElement, ['data-name', 'data-id'])}'`)
addLog(`CQL console created for the connection '${getAttributes(clusterElement, ['data-name', 'data-id'])}'`)
} catch (e) {}

/**
Expand Down Expand Up @@ -5327,8 +5329,8 @@
* Apply different effects on the work area UI
* Update the cluster's element in the clusters' list
*/
clusterElement.attr('data-connected', connected ? 'true' : 'false')
.children('div.status').addClass(connected ? 'success' : 'failure').removeClass(connected ? 'failure' : 'success')
// clusterElement.attr('data-connected', connected ? 'true' : 'false')
// .children('div.status').addClass(connected ? 'success' : 'failure').removeClass(connected ? 'failure' : 'success')

// Disable selected buttons
workareaElement.find('.disableable').toggleClass('disabled', !connected)
Expand Down Expand Up @@ -7100,7 +7102,7 @@
})

// Add the success state to the cluster's UI element
statusElement.removeClass('failure').addClass('success')
statusElement.removeClass('failure')

try {
// If the version of Cassandra is not v3 then skip this try-catch block
Expand Down Expand Up @@ -11925,7 +11927,7 @@

$(this).attr('disabled', isAlterState ? '' : null)
$(this).parent().toggleClass('invalid-warning', isAlterState)
$(this).toggleClass('is-invalid ignore-invalid', isAlterState)
$(this).removeClass('is-invalid ignore-invalid')

try {
if (!isAlterState)
Expand Down Expand Up @@ -12005,6 +12007,10 @@
if (minifyText(replicationStrategy) == minifyText('simplestrategy'))
throw 0

$('span.dynamic-rf').attr('mulang', 'data center replication factor')

Modules.Localization.applyLanguageSpecific($('span.dynamic-rf'))

$(this).removeClass('is-invalid')

$('input#keyspaceReplicationFactorSimpleStrategy').val(1).trigger('input')
Expand Down Expand Up @@ -12084,6 +12090,10 @@
return
} catch (e) {}

$('span.dynamic-rf').attr('mulang', 'replication factor')

Modules.Localization.applyLanguageSpecific($('span.dynamic-rf'))

setTimeout(() => $(this).addClass('is-invalid'), 250)

try {
Expand Down Expand Up @@ -13365,7 +13375,7 @@

$(this).attr('disabled', isAlterState ? '' : null)
$(this).parent().toggleClass('invalid-warning', isAlterState)
$(this).toggleClass('is-invalid ignore-invalid', isAlterState)
$(this).removeClass('is-invalid ignore-invalid')

try {
if (!isAlterState)
Expand Down Expand Up @@ -13788,7 +13798,7 @@

$(this).attr('disabled', isAlterState ? '' : null)
$(this).parent().toggleClass('invalid-warning', isAlterState)
$(this).toggleClass('is-invalid ignore-invalid', isAlterState)
$(this).removeClass('is-invalid ignore-invalid')

try {
if (!isAlterState)
Expand Down Expand Up @@ -16030,7 +16040,7 @@

$(this).attr('disabled', isAlterState ? '' : null)
$(this).parent().toggleClass('invalid-warning', isAlterState)
$(this).toggleClass('is-invalid ignore-invalid', isAlterState)
$(this).removeClass('is-invalid ignore-invalid')

try {
if (!isAlterState)
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added renderer/js/external/jstree/theme/extra/view.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

0 comments on commit ebeb985

Please sign in to comment.