Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat]: Change Partion Key and Clustering Key Icon to be different to Primary key icon to distinguish them #685

Open
millerjp opened this issue Jan 2, 2025 · 1 comment
Open

[feat]: Change Partion Key and Clustering Key Icon to be different to Primary key icon to distinguish them #685

millerjp opened this issue Jan 2, 2025 · 1 comment
Assignees
@mhmdkrmabd
Labels
enhancement New feature or request
Milestone
RightClick

Comments

@millerjp
Copy link
Contributor

millerjp commented Jan 2, 2025 •
edited
Loading

We need different icons to distinguish the different kinds of columns that can make up a primary key. Using the same key icon is not ideal.

When a column is a partition key use a hash icon like this to represent it
Screenshot 2025-01-03 at 09 46 17

When a column is a clustering key use a double arrow icon like this

Screenshot 2025-01-02 at 19 53 49

Update the tree so that columsn under Primary Key and Columns use these icons, update the Partition Key group icon and Clustering Key icon to match also.
@millerjp millerjp added the enhancement New feature or request label Jan 2, 2025
@millerjp millerjp added this to the RightClick milestone Jan 2, 2025
@millerjp millerjp changed the title [feat]: Change Partion Key and Clustering Key Icon to be different to Primary key icon to distnguish them [feat]: Change Partion Key and Clustering Key Icon to be different to Primary key icon to distinguish them Jan 2, 2025
mhmdkrmabd added a commit that referenced this issue Feb 18, 2025
@mhmdkrmabd
For ticket #685, improved the metadata treeview, changed icons for pa…
453137d 
…rtition and clustering keys

The icon of both; partition and clustering keys have been changed in order to be clearly distinguished
@mhmdkrmabd
Copy link
Collaborator

Image

digiserg pushed a commit that referenced this issue Feb 18, 2025
@mhmdkrmabd
All XS tickets in the right click milestone: #666, #591, #667, #663, …
ebeb985 
…#685, #684, #649, #596, #670, #577, #360, #522, and #682 (#726)

* For ticket #666, dynamic RF name based on strategy

When altering/creating a keyspace, the `Replication Factor` name would be changed to be `Data Center Replication Factor` in case the set strategy is `NetworkTopology`

* For ticket #591, added `Mandatory` badge to required fields on keyspace creation

- Now a badge `Mandatory` is showed for the `Keyspace Name` field; to tell that it's a required field to complete the creation process.

- Improved the style of other mandatory fields in connection addition process - host name and port -.

* For ticket #667, warning about keyspace name in alter process has been removed

The warning `The keyspace name can't be altered` has been removed; as the field is disabled already.

* For ticket #663, altering warning for name has been removed everywhere

- Similar to #667 ticket, the altering warning for standard table's name has been removed.
- Also, it has been removed when altering counter tables and UDTs.

* For ticket #685, improved the metadata treeview, changed icons for partition and clustering keys

The icon of both; partition and clustering keys have been changed in order to be clearly distinguished

* For ticket #684

* For ticket #649, and ticket #670 - handled in previous commits -

* For ticket #577

* For ticket #360

* For ticket #522

* For ticket #682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhmdkrmabd mhmdkrmabd

Labels
enhancement New feature or request
Projects
None yet
Milestone
RightClick
Development

No branches or pull requests
2 participants
@millerjp @mhmdkrmabd