refactor: consume htm from npm instead of an inlined minified copy - #66
Merged
Conversation
src/html.js previously carried a hand-copied, minified snapshot of htm's parser that no one could review or update. Replace it with an import of the published `htm/mini` build (added as a devDependency) bound to the same `h(type, props, children)` hyperscript. htm/mini matches the old copy's behavior — the discarded `new Map()` in the snapshot meant it was already cache-free. esbuild's `--bundle` inlines htm into dist/ at build time, so the published package stays zero-runtime-dependency. dist/html.js is 569 B, within the 600 B budget. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013do3MDHVoaetoPD229yExu
✅ Deploy Preview for demo-wcb ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for web-component-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add htm as dev dep