feat: make WebRTC timeout user-configurable #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While commit #a4bcc14283d5a00f6c6ea5247953cbeb832e0eae added a default WebRTC stream timeout and made it possible to override it, the commit did not provide any meaningful mechanism for users to do that. This commit adds two ways for users to override the default timeout with a `timeout_s` parameter in the URL, ie. `/webrtc?timeout_s=somevaluehere` or via `--webrtc-timeout_s` command-line argument. Signed-off-by: Nita Vesa <[email protected]>
WereCatf
force-pushed
the
configurable-webrtc-timeout
branch
from
2debddf to
31c837c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While commit a4bcc14 added a default WebRTC stream timeout and made it possible to override it, the commit did not provide any meaningful mechanism for users to do that. This commit adds two ways for users to override the default timeout with a
timeout_sparameter in the URL, ie./webrtc?timeout_s=somevaluehereor via--webrtc-timeout_scommand-line argument.