Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces continuous integration for the Core component by adding Swift build and test workflows while also refining string decoding in error handling paths. Key changes include:
- Updating string decoding in OpenAIClient.swift to handle non-UTF8 responses with a fallback message.
- Adjusting string decoding in KeychainHelper.swift to return an optional value.
- Adding a CI workflow (swift.yml) to build, test, and lint the project on macOS.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| azooKeyMac/InputController/OpenAIClient.swift | Refined error handling by switching to a safer UTF8 decoding with a fallback message. |
| azooKeyMac/Extensions/KeychainHelper.swift | Updated keychain decoding logic to use the optional-returning initializer. |
| .github/workflows/swift.yml | Added CI workflow for building, testing, and linting the project. |
Files not reviewed (1)
- azooKeyMac.xcodeproj/project.pbxproj: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a GitHub Actions workflow for Swift development, updates build settings in the Xcode project, and improves string decoding in the codebase. These changes enhance CI/CD processes, streamline project configuration, and improve error handling.
CI/CD Enhancements:
Added a new GitHub Actions workflow (
.github/workflows/swift.yml) that includes jobs for building and testing on macOS, runningxcodebuildtests, and enforcing SwiftLint for code quality.Xcode Project Configuration:
SYMROOTsetting from both the Debug and Release build configurations inazooKeyMac.xcodeproj/project.pbxproj, allowing Xcode to use its default build directory. [1] [2]Code Improvements:
KeychainHelperto useString(bytes:encoding:)for better handling of UTF-8 encoded data.OpenAIClientby usingString(bytes:encoding:)with a fallback message for non-UTF-8 encoded response bodies.