Conversation
- KeychainHelperのメソッドをasync/awaitで非同期化 - OpenAiApiKeyにキャッシュ機能を追加し、Keychainアクセスを最小化 - アプリ起動時にKeychainから値を非同期で読み込む処理を追加 これにより、UIスレッドのブロックを防ぎ、アプリケーションの応答性が向上
ensan-hcl
reviewed
Jun 4, 2025
Comment on lines
+87
to
+90
| // Keychainから設定値を非同期で読み込み | ||
| Task { | ||
| await Config.OpenAiApiKey.loadFromKeychain() | ||
| } |
Member
There was a problem hiding this comment.
これ、初回の利用時ってどういうことになる？キーチェーンに値が入っていない場合はアラート出ない？
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KeychainHelperのメソッドをasync/awaitで非同期化
OpenAiApiKeyにキャッシュ機能を追加し、Keychainアクセスを最小化
アプリ起動時にKeychainから値を非同期で読み込む処理を追加
これにより、UIスレッドのブロックを防ぎ、アプリケーションの応答性が向上