Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add optional pronunciation audio download for word cards #7

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: Add optional pronunciation audio download for word cards #7

wants to merge 1 commit into from

Conversation

s10
Copy link
Contributor

@s10 s10 commented Dec 23, 2024 •
edited
Loading

Add optional pronunciation audio download for word cards

@s10 s10 changed the title feat: Add audio with pronunciation to the word cards feat: Add optional pronunciation audio download for word cards Dec 23, 2024
@azymohliad
Copy link
Owner

Sounds cool! Hopefully the conflicts are straightforward to fix. Just FYI, card templates are now moved to individual HTML files, and note type fields are now defined in NoteTypeManager.FIELDS in notetypes.py. The word_info.py has seen many changes, but they seem unrelated to yours.

Most likely I'll have time to get back to the project and review this PR after Jan 10th.

@s10 s10 force-pushed the feat/pronounce branch 2 times, most recently from 8488d0a to 02aa02c Compare December 26, 2024 23:01
@azymohliad
Copy link
Owner

Just to be clear, this is still a draft not ready for review, right? The reason I merged my updates first without asking is because I assumed so.

@s10
Copy link
Contributor Author

s10 commented Dec 28, 2024 •
edited
Loading

This is a functioning WIP draft. I rebased it two days ago, and I will tidy it up in the coming days.

@azymohliad
Copy link
Owner

Ah, ok, then I understood it correctly. And yeah, no rush, I'll have more time to review it in January anyways

@s10 s10 force-pushed the feat/pronounce branch 2 times, most recently from 1a1ddb8 to dcb393d Compare January 4, 2025 13:21
@s10 s10 marked this pull request as ready for review January 4, 2025 13:57
@s10 s10 marked this pull request as draft January 6, 2025 19:33
@s10
Copy link
Contributor Author

s10 commented Jan 6, 2025

I returned PR to draft because of the rare bug when it downloads an audio file for the wrong word form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s10 @azymohliad